Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testnet-automation: Don't clobber testnet prefix #12527

Closed
wants to merge 1 commit into from
Closed

testnet-automation: Don't clobber testnet prefix #12527

wants to merge 1 commit into from

Conversation

t-nelson
Copy link
Contributor

Problem

testnet automation doesn't set any host-specific field in the testnet prefix, leading to agents clobbering each others testnets

Summary of Changes

Append hostname to script/user specified TESTNET_TAG

@t-nelson t-nelson requested a review from danpaul000 September 28, 2020 16:40
danpaul000
danpaul000 reviewed Sep 29, 2020
View reviewed changes
system-test/testnet-automation.sh
@@ -223,6 +223,9 @@ if [[ -z $NUMBER_OF_VALIDATOR_NODES ]]; then
exit 1
fi

dbName="$TESTNET_TAG"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So won't clobber the testnets, but you will have overlapping writes to the same db in this case if two hosts are running parallel networks with the same TESTNET_TAG

Copy link
Contributor

@danpaul000 danpaul000 Sep 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update init-metrics.sh and the call to it here

solana/system-test/testnet-automation.sh

Line 106 in 13ff6b2

"${REPO_ROOT}"/net/init-metrics.sh -e
to support the dynamic creation of new db's for this to work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah... yeah... are we worried about having a mess of DBs?

Would be nice if we could have just the one, then generate a UUID for each test run that's tagged to metrics, but I suspect that's a lot of plumbing elsewhere

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could set custom retention policies for dynamically-created DBs so they don't stick around for too long. The slackbot already creates a custom URL for each test that's run so it displays the db in question only for the time during which the test was running. If something simple like that works for you, that's fine. The bigger problem will come if/when you are having nodes from unrelated testnets writing to the same db at the same time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll look into that this evening and report back

@ryoqun ryoqun mentioned this pull request Sep 30, 2020
Closed
@stale
Copy link

stale bot commented Oct 7, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Oct 7, 2020
@stale
Copy link

stale bot commented Oct 14, 2020

This stale pull request has been automatically closed. Thank you for your contributions.

@stale stale bot closed this Oct 14, 2020
@ryoqun ryoqun reopened this Oct 14, 2020
@stale stale bot removed the stale [bot only] Added to stale content; results in auto-close after a week. label Oct 14, 2020
@stale
Copy link

stale bot commented Oct 21, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Oct 21, 2020
@t-nelson t-nelson removed the stale [bot only] Added to stale content; results in auto-close after a week. label Oct 21, 2020
@stale
Copy link

stale bot commented Oct 28, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Oct 28, 2020
@stale
Copy link

stale bot commented Nov 5, 2020

This stale pull request has been automatically closed. Thank you for your contributions.

@stale stale bot closed this Nov 5, 2020
@t-nelson t-nelson reopened this Nov 5, 2020
@stale stale bot removed the stale [bot only] Added to stale content; results in auto-close after a week. label Nov 5, 2020
@stale
Copy link

stale bot commented Nov 13, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Nov 13, 2020
@stale
Copy link

stale bot commented Nov 20, 2020

This stale pull request has been automatically closed. Thank you for your contributions.

@stale stale bot closed this Nov 20, 2020
@t-nelson t-nelson deleted the testnet-auto-prefix-noclobber branch March 2, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danpaul000 danpaul000 danpaul000 left review comments

Assignees
No one assigned
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t-nelson @danpaul000 @ryoqun