This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Tell verifiers when not to parallelize accounting #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch, many batches of transactions could be tossed into a single entry, but the parallelized accountant can only guarentee the transactions in the batch can be processed in parallel. This patch signals the historian to generate a new Entry after each batch. Validators must maintain sequential consistency across Entries.
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
==========================================
+ Coverage 96.29% 96.34% +0.05%
==========================================
Files 17 17
Lines 1620 1671 +51
==========================================
+ Hits 1560 1610 +50
- Misses 60 61 +1
Continue to review full report at Codecov.
|
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
This was referenced May 17, 2022
willhickey
pushed a commit
that referenced
this pull request
Mar 9, 2024
willhickey
added a commit
that referenced
this pull request
Mar 11, 2024
This reverts commit ed57e6a.
stevenbooke
pushed a commit
to stevenbooke/solana
that referenced
this pull request
Mar 18, 2024
This reverts commit ed57e6a.
palinko91
pushed a commit
to palinko91/solana
that referenced
this pull request
May 7, 2024
This reverts commit ed57e6a.
palinko91
pushed a commit
to palinko91/solana
that referenced
this pull request
May 7, 2024
This reverts commit ed57e6a.
segfaultdoc
pushed a commit
to jito-labs/solana
that referenced
this pull request
Aug 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, many batches of transactions could be tossed
into a single entry, but the parallelized accountant can only
guarentee the transactions in the batch can be processed in
parallel.
This patch signals the historian to generate a new Entry after
each batch. Validators must maintain sequential consistency
across Entries.