Fix propagation on startup from snapshot #12177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
dismissed
t-nelson’s stale review
Pull request has been modified.
|
Woah, nice bug! |
Codecov Report
@@ Coverage Diff @@
## master #12177 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 338 338
Lines 79397 79428 +31
=======================================
+ Hits 65177 65210 +33
+ Misses 14220 14218 -2 |
mergify bot
pushed a commit
that referenced
this pull request
Sep 11, 2020
(cherry picked from commit 9c490e0)
mergify bot
added a commit
that referenced
this pull request
Sep 11, 2020
(cherry picked from commit 9c490e0) Co-authored-by: carllin <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Sep 12, 2020
(cherry picked from commit 9c490e0)
t-nelson
pushed a commit
that referenced
this pull request
Sep 12, 2020
(cherry picked from commit 9c490e0)
mergify bot
added a commit
that referenced
this pull request
Sep 12, 2020
(cherry picked from commit 9c490e0) Co-authored-by: carllin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If the leader for slot
Nstarts from a snapshot of slotN, they will not get propagation confirmed, and will stop votingThanks @t-nelson for reporting!
Summary of Changes
Propagate votes for descendants of
Nto slotNitselfFixes #