Gate pointer alignment enforcement #12176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackcmay
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #12176 +/- ##
=========================================
- Coverage 82.1% 82.0% -0.1%
=========================================
Files 338 338
Lines 79397 79464 +67
=========================================
+ Hits 65186 65192 +6
- Misses 14211 14272 +61 |
mergify bot
pushed a commit
that referenced
this pull request
Sep 11, 2020
(cherry picked from commit ae7b15f) # Conflicts: # programs/bpf/tests/programs.rs
mergify bot
added a commit
that referenced
this pull request
Sep 12, 2020
* Gate pointer alignment enforcement (#12176) (cherry picked from commit ae7b15f) # Conflicts: # programs/bpf/tests/programs.rs * Fix conflicts Co-authored-by: Jack May <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Program syscalls were enforcing that the pointed passed from a program be aligned. Programs using the deprecated loader may be using unaligned pointers. This is causing a compatibility issue with mainnet-beta (#11973). Thanks, @ryoqun for finding this.
Summary of Changes
Gate the enforcement of pointer alignment on which loader is being used
Fixes #