Reduce cap by rent's leftover as temporary measure #12111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12111 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 337 337
Lines 79220 79223 +3
=======================================
+ Hits 65012 65025 +13
+ Misses 14208 14198 -10 |
|
mvines
previously approved these changes
Sep 8, 2020
runtime/src/bank.rs
Outdated
| self.distribute_rent_to_validators(&self.vote_accounts(), rent_to_be_distributed); | ||
| let leftover = | ||
| self.distribute_rent_to_validators(&self.vote_accounts(), rent_to_be_distributed); | ||
| self.capitalization.fetch_sub(leftover, Ordering::Relaxed); |
There was a problem hiding this comment.
Just to confirm, this is ok because capitalization is not a part of the bank hash right?
There was a problem hiding this comment.
Just to confirm, this is ok because
capitalizationis not a part of the bank hash right?
Exactly. :)
ryoqun
force-pushed
the
rent-leftover-cap-reduction
branch
from
f6a123f to
b00f1a5
Compare
mergify bot
pushed a commit
that referenced
this pull request
Sep 8, 2020
* Reduce cap by rent's leftover as temporary measure * Reset testnet cap. on start and more logs (cherry picked from commit 5b2442d)
mergify bot
added a commit
that referenced
this pull request
Sep 8, 2020
* Reduce cap by rent's leftover as temporary measure * Reset testnet cap. on start and more logs (cherry picked from commit 5b2442d) Co-authored-by: Ryo Onodera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
testnet's cap is busted now.
Summary of Changes
This is temporary fix, which can go without gating.
The underlying bug is now identified and the bug even resides in mainnet-beta/v1.2......
Context
found via capitalization work and blocking #11927