Change '>=' back to '>' to fix recycling of blobs/packets #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
suggested changes
Sep 11, 2018
|
@garious actually how would you test it, since it seems the external effects from going through that path are kind of the same. self.gc.len() will be the same, the only difference is if I got a re-used one or a new one but I'm not sure how I tell the difference in those. I guess I can go with the counter change then I can check those but it seems fragile. |
|
Modify the packet before recycling and |
sakridge
force-pushed
the
fix-strong-count-logic
branch
from
9139112 to
680e8bf
Compare
Recycler will have a strong ref to the item so it will be at least 1, >= will always prevent recycling.
sakridge
force-pushed
the
fix-strong-count-logic
branch
from
680e8bf to
da0b1e7
Compare
|
@garious test added, take a look when you can. |
garious
approved these changes
Sep 11, 2018
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
…olana-labs#1192) Bumps [rollup](https://github.com/rollup/rollup) from 2.38.4 to 2.38.5. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.38.4...v2.38.5) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Lichtso
pushed a commit
to Lichtso/solana
that referenced
this pull request
May 6, 2024
* program cache: reduce contention Before this change we used to take the write lock to extract(). This means that even in the ideal case (all programs are already cached), the cache was contended by all batches and all operations were serialized. With this change we now take the write lock only when we store a new entry in the cache, and take the read lock to extract(). This means that in the common case where most/all programs are cached, there is no contention and all batches progress in parallel. This improves node replay perf by 20-25% on current mnb traffic. * ProgramCache: remove SecondLevel structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recycler will have a strong ref to the item so it will be at
least 1, >= will always prevent recycling.