Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix region check #11651

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Fix region check #11651

merged 1 commit into from
Aug 17, 2020

Conversation

jackcmay
Copy link
Contributor

Problem

create_program_address region checks were flipped and relied on the sdk implementation but could be called directly

Summary of Changes

fix

Fixes #

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #11651 into master will increase coverage by 0.0%.
The diff coverage is 85.8%.

@@           Coverage Diff           @@
##           master   #11651   +/-   ##
=======================================
  Coverage    82.0%    82.1%           
=======================================
  Files         330      330           
  Lines       76059    76106   +47     
=======================================
+ Hits        62428    62503   +75     
+ Misses      13631    13603   -28     

@jackcmay jackcmay merged commit 768b386 into solana-labs:master Aug 17, 2020
@jackcmay jackcmay deleted the fix-region-check branch August 17, 2020 06:11
mergify bot pushed a commit that referenced this pull request Aug 21, 2020
(cherry picked from commit 768b386)

# Conflicts:
#	sdk/src/pubkey.rs
@mergify mergify bot mentioned this pull request Aug 21, 2020
mergify bot pushed a commit that referenced this pull request Aug 21, 2020
(cherry picked from commit 768b386)
@mergify mergify bot mentioned this pull request Aug 21, 2020
jackcmay added a commit that referenced this pull request Aug 22, 2020
(cherry picked from commit 768b386)

# Conflicts:
#	sdk/src/pubkey.rs
mergify bot added a commit that referenced this pull request Aug 22, 2020
(cherry picked from commit 768b386)

Co-authored-by: Jack May <[email protected]>
mergify bot added a commit that referenced this pull request Aug 22, 2020
* fix region checks (#11651)

(cherry picked from commit 768b386)

# Conflicts:
#	sdk/src/pubkey.rs

* resolve conflicts

Co-authored-by: Jack May <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant