Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC: getConfirmedSignaturesForAddress2 only returns confirmed signatures #11615

Merged
merged 2 commits into from
Aug 13, 2020
+10 −5
Merged

RPC: getConfirmedSignaturesForAddress2 only returns confirmed signatures #11615

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd5d103
Add failing test case
Aug 13, 2020
0cb8445
Limit to only rooted slots
Aug 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions ledger/src/blockstore.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2047,7 +2047,9 @@ impl Blockstore {
&& key_address == address
&& slot >= first_available_block
{
address_signatures.push((slot, signature));
if self.is_root(slot) {
address_signatures.push((slot, signature));
}
continue;
}
}
Expand Down Expand Up @@ -2078,7 +2080,9 @@ impl Blockstore {
&& key_address == address
&& slot >= first_available_block
{
address_signatures.push((slot, signature));
if self.is_root(slot) {
address_signatures.push((slot, signature));
}
continue;
}
}
Expand Down Expand Up @@ -6337,7 +6341,7 @@ pub mod tests {
let address0 = Pubkey::new_rand();
let address1 = Pubkey::new_rand();

for slot in 2..=7 {
for slot in 2..=8 {
let entries = make_slot_entries_with_transaction_addresses(&[
address0, address1, address0, address1,
]);
Expand All @@ -6363,8 +6367,9 @@ pub mod tests {
}
}
}
blockstore.set_roots(&[1, 2, 3, 4, 5, 6, 7]).unwrap();
let highest_confirmed_root = 7;
// Leave one slot unrooted to test only returns confirmed signatures
blockstore.set_roots(&[1, 2, 4, 5, 6, 7, 8]).unwrap();
let highest_confirmed_root = 8;

// Fetch all signatures for address 0 at once...
let all0 = blockstore
Expand Down