This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Specify loader when bootstrapping BPF programs #11571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11571 +/- ##
=========================================
+ Coverage 81.8% 82.0% +0.2%
=========================================
Files 327 330 +3
Lines 75616 75869 +253
=========================================
+ Hits 61889 62248 +359
+ Misses 13727 13621 -106 |
This was referenced Aug 18, 2020
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2020
(cherry picked from commit 0a94e7e)
jackcmay
added a commit
that referenced
this pull request
Aug 25, 2020
(cherry picked from commit 0a94e7e) Co-authored-by: Jack May <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Sep 10, 2020
(cherry picked from commit 0a94e7e) # Conflicts: # fetch-spl.sh
t-nelson
pushed a commit
that referenced
this pull request
Sep 10, 2020
(cherry picked from commit 0a94e7e)
mergify bot
added a commit
that referenced
this pull request
Sep 10, 2020
(cherry picked from commit 0a94e7e) Co-authored-by: Jack May <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Genesis is assuming the default loader when adding BPF programs and the default loader has been recently updated. Programs compatible with the old loader fail when loaded by the new one.
Summary of Changes
Allow callers to specify what loader to use when adding the program and also update the SPL scripts to specify the compatible loader
Fixes #