Unified signature for create_program_address #11460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11460 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 323 321 -2
Lines 75545 75462 -83
=======================================
- Hits 61897 61845 -52
+ Misses 13648 13617 -31 |
mergify bot
pushed a commit
that referenced
this pull request
Aug 10, 2020
(cherry picked from commit 140b239)
mergify bot
added a commit
that referenced
this pull request
Aug 10, 2020
(cherry picked from commit 140b239) Co-authored-by: Jack May <[email protected]>
CriesofCarrots
pushed a commit
to CriesofCarrots/solana
that referenced
this pull request
Aug 10, 2020
|
@jackcmay Just noticed that this should probably rather use |
This was referenced Aug 18, 2020
mergify bot
pushed a commit
that referenced
this pull request
Aug 21, 2020
(cherry picked from commit 140b239)
mergify bot
added a commit
that referenced
this pull request
Aug 22, 2020
(cherry picked from commit 140b239) Co-authored-by: Jack May <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Two different function signatures for
create_program_addresswhether you are calling from program or notSummary of Changes
Unify them
Fixes #