Add method to return hash of bank state #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
reviewed
Sep 7, 2018
src/bank.rs
Outdated
| @@ -637,6 +638,14 @@ impl Bank { | |||
| false | |||
| } | |||
|
|
|||
| pub fn hash_bank_state(&self) -> Hash { | |||
There was a problem hiding this comment.
How about the name hash_internal_state()? And add some documentation about its intended use.
src/bank.rs
Outdated
| @@ -974,6 +996,15 @@ mod tests { | |||
| (genesis.into_iter().chain(block), mint.pubkey()) | |||
| } | |||
|
|
|||
| fn create_sample_ledger_with_mint_and_keypairs( | |||
| mint: Mint, | |||
There was a problem hiding this comment.
No need to move the Mint here. Borrow it, and then you don't need to return its Pubkey.
There was a problem hiding this comment.
Oh, duh. I toyed with this, but missed axing the Pubkey.
src/mint.rs
Outdated
| @@ -7,7 +7,7 @@ use signature::{Keypair, KeypairUtil, Pubkey}; | |||
| use transaction::Transaction; | |||
| use untrusted::Input; | |||
|
|
|||
| #[derive(Serialize, Deserialize, Debug)] | |||
| #[derive(Serialize, Deserialize, Debug, Clone)] | |||
CriesofCarrots
force-pushed
the
hash_bank
branch
2 times, most recently
from
d0d4d48 to
d35633e
Compare
CriesofCarrots
force-pushed
the
hash_bank
branch
from
d35633e to
a867536
Compare
garious
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1130