Fix compilation failure on windows #10983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs rebase on #10986. I've confirmed windows now builds with this pr. :): https://travis-ci.com/github/solana-labs/solana/jobs/359595539#L600 |
ryoqun
changed the title
ryoqun
commented
Jul 10, 2020
.travis.yml
Outdated
| @@ -37,24 +32,6 @@ jobs: | |||
| script: | |||
| - source ci/env.sh | |||
| - ci/publish-tarball.sh | |||
| deploy: | |||
There was a problem hiding this comment.
revert these removals before merging!!!
ryoqun
force-pushed
the
symlink-build-rs-windows
branch
from
27d5256 to
22ae7aa
Compare
rebased on #11000 (supersedes #10986) and windows build is fixed: https://travis-ci.com/github/solana-labs/solana/jobs/360070195 |
ryoqun
changed the title
|
Windows build on master restored: https://travis-ci.com/github/solana-labs/solana/jobs/360299694#L625 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#8012 started to cause master CI travis windows build to fail.
Summary of Changes
Fixes https://travis-ci.com/github/solana-labs/solana/jobs/359548477#L616