Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce logging lines #10835

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Reduce logging lines #10835

merged 1 commit into from
Jun 29, 2020

Conversation

sakridge
Copy link
Member

Problem

Too many logging lines caused by pretty-printing and logging too often.

Summary of Changes

Don't use pretty-print which can easily be restored in post-processing and reduce interval of some datapoints.

Fixes #

@sakridge sakridge requested a review from carllin June 29, 2020 21:33
@sakridge sakridge added the v1.2 label Jun 29, 2020
@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #10835 into master will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #10835   +/-   ##
=======================================
  Coverage    81.8%    81.9%           
=======================================
  Files         303      303           
  Lines       71087    71087           
=======================================
+ Hits        58220    58224    +4     
+ Misses      12867    12863    -4     

@sakridge sakridge merged commit d9b389f into solana-labs:master Jun 29, 2020
@sakridge sakridge deleted the reduce-logging branch June 29, 2020 22:57
mergify bot pushed a commit that referenced this pull request Jun 29, 2020
(cherry picked from commit d9b389f)
mergify bot added a commit that referenced this pull request Jun 30, 2020
(cherry picked from commit d9b389f)

Co-authored-by: sakridge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants