This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Rework backup and clear function #10751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeyakovenko
previously approved these changes
Jun 23, 2020
Codecov Report
@@ Coverage Diff @@
## master #10751 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 302 302
Lines 70799 70820 +21
=======================================
+ Hits 57934 57961 +27
+ Misses 12865 12859 -6 |
carllin
reviewed
Jun 23, 2020
carllin
reviewed
Jun 23, 2020
mergify
bot
dismissed
aeyakovenko’s stale review
Pull request has been modified.
carllin
approved these changes
Jun 23, 2020
sakridge
added
the
automerge
mergify bot
pushed a commit
that referenced
this pull request
Jun 23, 2020
(cherry picked from commit a1ef921)
mergify bot
added a commit
that referenced
this pull request
Jun 23, 2020
(cherry picked from commit a1ef921) Co-authored-by: sakridge <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The validator will start to process shreds with an incorrect version when restarting with a hard fork creating invalid banks before the backup and clear function can remove those slots.
Summary of Changes
Move backup and clear to before blockstore is processed so that those slots do not get processed. Search for any incompatible shred versions and remove those from blockstore.
Fixes #