Add {Vote, Tower}::last_voted_slot() #10734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carllin Could you take a look at this? |
Codecov Report
@@ Coverage Diff @@
## master #10734 +/- ##
=========================================
- Coverage 81.7% 81.7% -0.1%
=========================================
Files 300 300
Lines 70509 70513 +4
=========================================
- Hits 57660 57641 -19
- Misses 12849 12872 +23 |
carllin
reviewed
Jun 23, 2020
| @@ -54,6 +54,10 @@ impl Vote { | |||
| timestamp: None, | |||
| } | |||
| } | |||
|
|
|||
| pub fn last_voted_slot(&self) -> Option<Slot> { | |||
| self.slots.last().copied() | |||
There was a problem hiding this comment.
I need to start being more mindful to do this over .cloned() when possible, good reminder!
carllin
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
To address this, I need to reset
self.last_votewhen the snapshot is well descedent of the fork at which the previously-persisted Tower was at.While reading code, I just realized various callers of
Tower::last_vote()just neededlast_slotin it.Summary of Changes
Define appropriate getter:
{Tower/Vote}::last_voted_slot().Also this should remove the unneeded cloning of
Votewhile passing around.This should contain no functional change.
Part of #10718