Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix udp port check retry and check all udp ports (bp #10385) #10577

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 14, 2020

This is an automated backport of pull request #10385 done by Mergify

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the simulator.

Finally, you can contact us on https://mergify.io/

* Don't start if udp port is really closed

* Fully check all udp ports

* Remove test code.......

* Add tests and adjust impl a bit

* Add comment

* Move comment a bit

* Move a bit

* clean ups

(cherry picked from commit a39df7e)
@mergify mergify bot added the automerge Merge this Pull Request automatically once CI passes label Jun 14, 2020
@solana-grimes
Copy link
Contributor

💔 Unable to automerge due to CI failure

@solana-grimes solana-grimes removed the automerge Merge this Pull Request automatically once CI passes label Jun 14, 2020
@mergify mergify bot added the automerge Merge this Pull Request automatically once CI passes label Jun 15, 2020
@solana-grimes solana-grimes removed the automerge Merge this Pull Request automatically once CI passes label Jun 15, 2020
@solana-grimes
Copy link
Contributor

💔 Unable to automerge due to CI failure

@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #10577 into v1.2 will increase coverage by 0.0%.
The diff coverage is 95.0%.

@@          Coverage Diff           @@
##            v1.2   #10577   +/-   ##
======================================
  Coverage   81.8%    81.8%           
======================================
  Files        297      297           
  Lines      69993    70057   +64     
======================================
+ Hits       57284    57363   +79     
+ Misses     12709    12694   -15     

@ryoqun ryoqun added the automerge Merge this Pull Request automatically once CI passes label Jun 15, 2020
@solana-grimes solana-grimes merged commit 133baa8 into v1.2 Jun 15, 2020
@mergify mergify bot deleted the mergify/bp/v1.2/pr-10385 branch June 15, 2020 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants