This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Fix perf-libs version detection #10571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
commented
Jun 14, 2020
| @@ -6,7 +6,7 @@ VERSION=$PERF_LIBS_VERSION-1 | |||
| set -e | |||
| cd "$(dirname "$0")" | |||
|
|
|||
| if [[ ! -f target/perf-libs/.$VERSION ]]; then | |||
There was a problem hiding this comment.
This check is broken! froome in its cache at /var/lib/buildkite-agent/builds/froome-1/solana-labs/solana-secondary/target/perf-libs had the files .v0.18.0-1 and .v0.18.1-1. What happened was:
.v0.18.1-1was installed on froome.v0.18.0-1was installed on froome
Now all future.v0.18.1-1installs claim success even though it's.v0.18.0-1.
A total fluke that we haven't run into this in the past.
sakridge
approved these changes
Jun 14, 2020
mergify bot
pushed a commit
that referenced
this pull request
Jun 14, 2020
automerge (cherry picked from commit 0d38257)
mergify bot
pushed a commit
that referenced
this pull request
Jun 14, 2020
automerge (cherry picked from commit 0d38257)
solana-grimes
pushed a commit
that referenced
this pull request
Jun 14, 2020
solana-grimes
pushed a commit
that referenced
this pull request
Jun 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.