Add mechanism to get blockhash's last valid slot #10239
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10239 +/- ##
=========================================
- Coverage 81.5% 81.3% -0.2%
=========================================
Files 288 288
Lines 66608 66665 +57
=========================================
- Hits 54303 54263 -40
- Misses 12305 12402 +97 |
docs/src/apps/jsonrpc-api.md
Outdated
| {"jsonrpc":"2.0","result":{"context":{"slot":1},"value":{"blockhash":"CSymwgTNX1j3E4qhKfJAUE41nBWEwXufoYryPbkde5RR","feeCalculator":{"lamportsPerSignature":5000}}},"id":1} | ||
| ``` | ||
|
|
||
| ### getRecentBlockhashLastValidSlot |
There was a problem hiding this comment.
What do you think of a name like getFees? No change in functionality.
There was a problem hiding this comment.
I'm definitely up for a shorter name, although I'm not sure getFees really describes what you're getting. I'll sleep on it...
There was a problem hiding this comment.
My thought there is that a blockhash and its expiration slot are both necessary means of qualifying the fee parameters. That is, if you send a signed transaction including the given blockhash by the given slot, the transaction fee is guaranteed to be determined by the given fee parameters. Deterministic blockhash expiration turns out to be a bonus feature.
There was a problem hiding this comment.
Yeah, that makes some sense, and I didn't think of anything better overnight. (I was toying with getRecentFees for a bit, but I think I mostly liked it because it would land next to getRecentBlockhash in the docs.) I'll push getFees and see how it looks
CriesofCarrots
added
the
automerge
automerge (cherry picked from commit 4e431bc)
Problem
It can be crucial for clients to know if a particular blockhash has expired.
getFeeCalculatorForBlockhashoffers one way to test this, but it would be a lot easier to know the expiration slot concretely.re: #10054 (comment)
Summary of Changes
getRecentBlockhashLastValidSlotrpc endpoint that returns a blockhash with its last valid slot, and expose last-valid-slot inRpcClient::get_recent_blockhash_with_commitmentI've left application of last_valid_slot in various solana client crates, like solana-tokens, solana-bench-tps, or solana-cli
ping, for separate prs. In particular, solana-bench-tps would require exposing last_valid_slot in ThinClient (perhaps via the Client trait), and so deserves additional consideration.Replaces #10162 and #10237