Prevent privilege escalation #10232
Merged
Prevent privilege escalation #10232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackcmay
force-pushed
the
priv-inheritence
branch
from
f310e5f to
39a23a8
Compare
garious
reviewed
May 25, 2020
jackcmay
force-pushed
the
priv-inheritence
branch
from
5c17768 to
6072a02
Compare
jackcmay
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #10232 +/- ##
=========================================
- Coverage 81.4% 81.4% -0.1%
=========================================
Files 282 282
Lines 65979 65934 -45
=========================================
- Hits 53764 53701 -63
- Misses 12215 12233 +18 |
mergify bot
pushed a commit
that referenced
this pull request
May 26, 2020
automerge (cherry picked from commit 03abd3d)
solana-grimes
pushed a commit
that referenced
this pull request
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cross-program invocations refer to the original transaction to enforce the
is_signerandis_writableattributes of invoked instructions. Doing so respects the original transaction's privileges but allows a privilege escalation between programs. Even though the original transaction authorizes the behavior, it is a large foot gun because it relies on a careful review of the programs being invoked.Summary of Changes
Enforce invoked instructions privileges against the calling instruction's privileges rather than the original transaction's.
Fixes #