Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validator voting when no transactions are occurring on the network #711

Closed
mvines opened this issue Jul 19, 2018 · 1 comment
Closed

Fix validator voting when no transactions are occurring on the network #711

mvines opened this issue Jul 19, 2018 · 1 comment
Assignees
@mvines
Milestone
v0.8 Windansea

Comments

@mvines
Copy link
Member

mvines commented Jul 19, 2018

All validators should be continually voting on either the last transaction or the last vote (which is also a transaction) at a rate of VOTE_TIMEOUT_MS. But if no new transaction occurs after VOTE_TIMEOUT_MS, the validator will stop voting until the next transaction is seen. Instead after VOTE_TIMEOUT_MS it should vote on whatever the last transaction seen is, and if it's the same transaction then it can just vote on it again.

ref: https://github.com/solana-labs/solana/blob/master/src/replicate_stage.rs#L65
@mvines mvines added this to the v0.8.0 milestone Jul 19, 2018
@mvines mvines self-assigned this Jul 19, 2018
@mvines
Copy link
Member Author

mvines commented Jul 31, 2018

Fixed by #718

@mvines mvines closed this as completed Jul 31, 2018
vkomenda pushed a commit to vkomenda/solana that referenced this issue Aug 29, 2021
@aeyakovenko @joncinque
Use u128 for all the math but store in u64 (solana-labs#711)
64a362c 
* Use u128 for all the math but store in u64

* tests

* missing changes

* bulds

* specific conversion failure

* fix tests

* use large numbers

* Rebase and fix merge issue from new tests

Co-authored-by: Jon Cinque <[email protected]>
@n4st0r n4st0r mentioned this issue Mar 11, 2024
Open
lijunwangs pushed a commit to lijunwangs/solana that referenced this issue Apr 10, 2024
@kevinheavey
svm: move bpf-loader-program to dev-dependencies (solana-labs#711)
ff8a25b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvines mvines

Labels
None yet
Projects
None yet
Milestone
v0.8 Windansea
Development

No branches or pull requests
1 participant
@mvines