Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower cyclomatic complexity of streamer::recv_window() #586

Closed
garious opened this issue Jul 11, 2018 · 0 comments
Closed

Lower cyclomatic complexity of streamer::recv_window() #586

garious opened this issue Jul 11, 2018 · 0 comments
Assignees

Comments

@garious
Copy link
Contributor

garious commented Jul 11, 2018

One function with 200 LoC and cyclomatic complexity of 34! Break it up.

https://github.com/solana-labs/solana/blob/master/src/streamer.rs#L252

@garious garious added this to the v0.8.0 milestone Jul 11, 2018
garious added a commit to garious/solana that referenced this issue Jul 12, 2018
garious added a commit to garious/solana that referenced this issue Jul 12, 2018
garious added a commit to garious/solana that referenced this issue Jul 12, 2018
vkomenda pushed a commit to vkomenda/solana that referenced this issue Aug 29, 2021
…olana-labs#586)

* Pass TokenSwap state into the constructor to simplify function calls

* WIP: Update program to return token_program_id

* Add tokenProgramId to js TokenSwapInfo object

* Address pr comments

* Remove TokenSwapInfo and use loadTokenSwap as the primary way to fetch TokenSwap metadata

* Fix module.d.ts

* Address pr comments

* Clarification on comments

Co-authored-by: Yutaro Mori <[email protected]>
godmodegalactus pushed a commit to godmodegalactus/solana that referenced this issue Mar 22, 2024
Backport clone derivation (416) (solana-labs#418)

backports solana-labs#430: update jito-programs (solana-labs#432)

Backport solana-labs#446 to v1.17 (solana-labs#448)

[JIT-1661] Faster Autosnapshot (solana-labs#445)

v1.17: Backport solana-labs#449 (solana-labs#451)

backports solana-labs#419: add upsert to accountoverrides (solana-labs#421)

backport 428 runtime-plugin (solana-labs#458)

[JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.17) (solana-labs#499)

Backport solana-labs#500 to v1.17 (solana-labs#507)

Backport solana-labs#520: add priority fees to mev claim (solana-labs#525)

Faster MEV tip claiming (v1.17) (solana-labs#568)

Backport Release Fixes (solana-labs#586)
godmodegalactus pushed a commit to godmodegalactus/solana that referenced this issue Mar 28, 2024
Backport clone derivation (416) (solana-labs#418)

backports solana-labs#430: update jito-programs (solana-labs#432)

Backport solana-labs#446 to v1.17 (solana-labs#448)

[JIT-1661] Faster Autosnapshot (solana-labs#445)

v1.17: Backport solana-labs#449 (solana-labs#451)

backports solana-labs#419: add upsert to accountoverrides (solana-labs#421)

backport 428 runtime-plugin (solana-labs#458)

[JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.17) (solana-labs#499)

Backport solana-labs#500 to v1.17 (solana-labs#507)

Backport solana-labs#520: add priority fees to mev claim (solana-labs#525)

Faster MEV tip claiming (v1.17) (solana-labs#568)

Backport Release Fixes (solana-labs#586)
buffalojoec added a commit to buffalojoec/solana that referenced this issue Apr 5, 2024
godmodegalactus pushed a commit to blockworks-foundation/solana that referenced this issue Apr 15, 2024
Backport clone derivation (416) (solana-labs#418)

backports solana-labs#430: update jito-programs (solana-labs#432)

Backport solana-labs#446 to v1.17 (solana-labs#448)

[JIT-1661] Faster Autosnapshot (solana-labs#445)

v1.17: Backport solana-labs#449 (solana-labs#451)

backports solana-labs#419: add upsert to accountoverrides (solana-labs#421)

backport 428 runtime-plugin (solana-labs#458)

[JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.17) (solana-labs#499)

Backport solana-labs#500 to v1.17 (solana-labs#507)

Backport solana-labs#520: add priority fees to mev claim (solana-labs#525)

Faster MEV tip claiming (v1.17) (solana-labs#568)

Backport Release Fixes (solana-labs#586)
vovkman pushed a commit to helius-labs/solana that referenced this issue May 11, 2024
Backport clone derivation (416) (solana-labs#418)

backports solana-labs#430: update jito-programs (solana-labs#432)

Backport solana-labs#446 to v1.17 (solana-labs#448)

[JIT-1661] Faster Autosnapshot (solana-labs#445)

v1.17: Backport solana-labs#449 (solana-labs#451)

backports solana-labs#419: add upsert to accountoverrides (solana-labs#421)

backport 428 runtime-plugin (solana-labs#458)

[JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.17) (solana-labs#499)

Backport solana-labs#500 to v1.17 (solana-labs#507)

Backport solana-labs#520: add priority fees to mev claim (solana-labs#525)

Faster MEV tip claiming (v1.17) (solana-labs#568)

Backport Release Fixes (solana-labs#586)

Update release URLs for jito-solana (solana-labs#589)

Backports solana-labs#595: correctly initialize account overrides (solana-labs#599)

Fix: Ensure set contact info to UDP port instead of QUIC (solana-labs#601)

Buffer bundles that exceed processing time and make the allowed processing time longer (solana-labs#609)
godmodegalactus pushed a commit to blockworks-foundation/solana that referenced this issue May 30, 2024
Backport clone derivation (416) (solana-labs#418)

backports solana-labs#430: update jito-programs (solana-labs#432)

Backport solana-labs#446 to v1.17 (solana-labs#448)

[JIT-1661] Faster Autosnapshot (solana-labs#445)

v1.17: Backport solana-labs#449 (solana-labs#451)

backports solana-labs#419: add upsert to accountoverrides (solana-labs#421)

backport 428 runtime-plugin (solana-labs#458)

[JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.17) (solana-labs#499)

Backport solana-labs#500 to v1.17 (solana-labs#507)

Backport solana-labs#520: add priority fees to mev claim (solana-labs#525)

Faster MEV tip claiming (v1.17) (solana-labs#568)

Backport Release Fixes (solana-labs#586)

Update release URLs for jito-solana (solana-labs#589)

Backports solana-labs#595: correctly initialize account overrides (solana-labs#599)

Fix: Ensure set contact info to UDP port instead of QUIC (solana-labs#601)

Buffer bundles that exceed processing time and make the allowed processing time longer (solana-labs#609)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants