Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unignore flaky test_banking_stage_entryfication #5660

Closed
mvines opened this issue Aug 26, 2019 · 0 comments · Fixed by #6251
Closed

Unignore flaky test_banking_stage_entryfication #5660

mvines opened this issue Aug 26, 2019 · 0 comments · Fixed by #6251
Milestone
Cloud Nine v0.20.0

Comments

@mvines
Copy link
Member

mvines commented Aug 26, 2019

Problem

#5659

Proposed Solution

Debug the race condition exposed by test_banking_stage_entryfication, fix it, then revert #5659
@mvines mvines added this to the Jaws v0.19.0 milestone Aug 26, 2019
ryoqun added a commit to ryoqun/solana that referenced this issue Oct 7, 2019
@ryoqun
Stabilize some banking stage tests
2262ee1 
Fixes solana-labs#5660
@ryoqun ryoqun mentioned this issue Oct 7, 2019
Merged
carllin pushed a commit that referenced this issue Oct 16, 2019
@ryoqun @carllin
Stabilize some banking stage tests (#6251)
e267dfa 
* Stabilize some banking stage tests

Fixes #5660

* Fix CI...

* clean up

* Fix ci

* Address review nits

* Use bank.max_tick_height due to off-by-one for no PohRecord's clearing bank

* Fix CI...

* Use bank.max_tick_height() instead for clarity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Cloud Nine v0.20.0
Development

Successfully merging a pull request may close this issue.

Stabilize some banking stage tests ryoqun/solana
1 participant
@mvines