Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fullnode shouldn't assume its peer can receive on the same UDP socket it sent a datagram from #497

Closed
mvines opened this issue Jun 29, 2018 · 1 comment
Closed

Fullnode shouldn't assume its peer can receive on the same UDP socket it sent a datagram from #497

mvines opened this issue Jun 29, 2018 · 1 comment

Comments

@mvines
Copy link
Member

mvines commented Jun 29, 2018

The requests channel currently assumes the UDP socket is bidirectional, which it may not be thanks to NATs. Other channels may (?) have similar problems. See the TODOs in src/nat.rs that were introduced via #494 for more context
@mvines mvines added this to the The Future! milestone Jun 29, 2018
@mvines
Copy link
Member Author

mvines commented Jul 2, 2018

This issue is mostly gibberish. Real fix is at #530

@mvines mvines closed this as completed Jul 2, 2018
@garious garious removed this from the The Future! milestone Jul 18, 2018
CriesofCarrots pushed a commit that referenced this issue Feb 28, 2020
@jstarry
fix: graceful fallback when minimum balance request fails (#497)
3abf8d4
mvines pushed a commit to mvines/solana that referenced this issue Jun 15, 2020
@jstarry @mvines
fix: graceful fallback when minimum balance request fails (solana-lab…
427ac9e 
…s#497)
mvines pushed a commit that referenced this issue Jun 15, 2020
@jstarry @mvines
fix: graceful fallback when minimum balance request fails (#497)
d4a2384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garious @mvines