Gossip CrdsValue::Vote messages are not properly signed #3207
Milestone
Comments
|
@sagar-solana A vote doesn't need a wallclock per-se. The blockhash that the vote is signed for can be translated to a wallclock. Replay stage can register any blockhash it observes with cluster_info, which can then use the mapping to translate into a wallclock. Any votes that are not in the mapping can be dropped. |
|
Oh that's smart. Okay I'll think about it and bug you if I have questions ;) |
willhickey
pushed a commit
to willhickey/solana
that referenced
this issue
Oct 29, 2024
) (solana-labs#3207) ci: remove deprecated macos-12 image (solana-labs#3202) ci: use macos-13 for client_targets pipeline (cherry picked from commit c6e8239) Co-authored-by: Yihau Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
CrdsValue::Votes in gossip were being signed (even though the vote tx contained within is signed) only because the tx doesn't carry a wallclockProposed Solution
Consider adding wallclocks to vote transactions so that votes on gossip are secure again.
The text was updated successfully, but these errors were encountered: