Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Gate: enable request heap frame instruction #30076

Open
tao-stones opened this issue Feb 2, 2023 · 0 comments
Open

Feature Gate: enable request heap frame instruction #30076

tao-stones opened this issue Feb 2, 2023 · 0 comments
Labels
feature-gate Pull Request adds or modifies a runtime feature gate

Comments

@tao-stones
Copy link
Contributor

tao-stones commented Feb 2, 2023 •
edited
Loading

Description

Add feature gate enable_request_heap_frame_ix, it's default value false ensures v1.14+ will maintain consensus with v1.13, whose behavior is prioritization fee will be ignored (eg set to 0) if same transaction includes compute_budget::request_heap_frame instruction, regardless if compute_budget::set_compute_unit_price is set.

Once the feature gate is enabled (after mainnet-beta is on v1.14), the logically correct behavior will be exhibited - all 3 compute_budget instructions will be honored from same transaction.

This feature gate is for ClusterType::MainnetBeta only, since it only need to match to v1.13

Feature ID

Hr1nUA9b7NJ6eChS26o7Vi8gYYDDwWD3YeBfzJkTbU86

Activation Method

Single Core Contributor

Minimum Beta Version

No response

Minimum Stable Version

No response

Testnet Activation Epoch

524

Devnet Activation Epoch

562

Mainnet-Beta Activation Epoch

503
@tao-stones tao-stones added the feature-gate Pull Request adds or modifies a runtime feature gate label Feb 2, 2023
@tao-stones tao-stones mentioned this issue Feb 2, 2023
Merged
@tao-stones tao-stones reopened this Feb 8, 2023
tao-stones added a commit to tao-stones/solana that referenced this issue Sep 13, 2023
@tao-stones
cleanup feature: enable request heap frame instruction solana-labs#30076
b9da7f4
@tao-stones tao-stones mentioned this issue Sep 13, 2023
Merged
tao-stones added a commit that referenced this issue Sep 18, 2023
@tao-stones
cleanup feature: enable request heap frame instruction #30076 (#33243)
8b8a21a 
* cleanup feature: enable request heap frame instruction #30076

* update sbf tests

* removed out dated comments and test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tao-stones