Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expired checkpoints aren't freed #2556

Closed
aeyakovenko opened this issue Jan 25, 2019 · 3 comments
Closed

Expired checkpoints aren't freed #2556

aeyakovenko opened this issue Jan 25, 2019 · 3 comments
Milestone
Trestles v0.16.0

Comments

@aeyakovenko
Copy link
Member

Problem

Checkpoints cannot be stored forever because they take up space.

Proposed Solution

#2289

The checkpoint is merged_into_root in the forks.rs module
@garious garious changed the title expired checkpionts are unrolled, or dequeued (GC of the bank occurs here) Expired checkpoints aren't freed Feb 2, 2019
@mvines mvines added this to the Silver Strand v0.14.0 milestone Apr 8, 2019
@mvines
Copy link
Member

mvines commented Jun 19, 2019

@aeyakovenko - do you know if this is still an issue?

@aeyakovenko
Copy link
Member Author

Nope

@pgarg66
Copy link
Contributor

pgarg66 commented Jun 19, 2019

Looks like the checkpoints now map to bank (per slot). The bank objects get freed when they get merged with root. Also, any bank that cannot be merged, gets pruned.

So, this issue should be fixed. @aeyakovenko does that sound right?

wen-coding pushed a commit to wen-coding/solana that referenced this issue Aug 13, 2024
@apfitzge
prioritization_fee_cache: remove get_account_locks (solana-labs#2556)
8b22b92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Trestles v0.16.0
Development

No branches or pull requests
3 participants
@aeyakovenko @mvines @pgarg66