Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Gate: drop redundant turbine propagation path #24352

Closed
behzadnouri opened this issue Apr 14, 2022 · 3 comments
Closed

Feature Gate: drop redundant turbine propagation path #24352

behzadnouri opened this issue Apr 14, 2022 · 3 comments
Assignees
Labels
feature-gate Pull Request adds or modifies a runtime feature gate

Comments

@behzadnouri
Copy link
Contributor

behzadnouri commented Apr 14, 2022

Description

Most nodes in the cluster receive the same shred from two different
nodes: parent, and the first node of their neighborhood:
https://github.com/solana-labs/solana/blob/a8c695ba5/core/src/cluster_nodes.rs#L178-L197

#24351 simplifies the broadcast tree by dropping the redundant
propagation path and removing the 2x fanout at root node.

All nodes in the cluster should adopt the new propagation tree at the same time;
otherwise because different nodes construct the propagation tree differently,
shreds don't get propagated fully across the cluster.
Therefore the change should be feature gated.

Feature ID

4Di3y24QFLt5QEUPZtbnjyfQKfm6ZMTfa6Dw1psfoMKU

Activation Method

Single Core Contributor

Testnet Activation Epoch

326

Devnet Activation Epoch

324

Mainnet-Beta Activation Epoch

No response

@behzadnouri behzadnouri added the feature-gate Pull Request adds or modifies a runtime feature gate label Apr 14, 2022
@behzadnouri behzadnouri self-assigned this Apr 14, 2022
@blocknxt
Copy link

blocknxt commented Jun 24, 2022

Any thoughts on when this will be enabled on MB ?.

@behzadnouri
Copy link
Contributor Author

@blocknxt doing some performance optimizations throughout the pipeline; after that will activate this feature.
Curious why you would be interested in this feature activation?

@bw-solana
Copy link
Contributor

bw-solana commented Jan 26, 2023

Reminder to please update Turbine documentation when this feature is enabled on MNB. Updated docs PR here: #29985

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Development

No branches or pull requests

3 participants