-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
findProgramAddress does not need to be async #23184
Comments
yangli-io
added a commit
to yangli-io/solana
that referenced
this issue
Feb 16, 2022
yangli-io
added a commit
to yangli-io/solana
that referenced
this issue
Feb 16, 2022
yangli-io
added a commit
to yangli-io/solana
that referenced
this issue
Feb 17, 2022
joncinque
pushed a commit
that referenced
this issue
Apr 18, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this issue
Jun 30, 2022
solana-labs#23185) * fix: remove async for createProgramAddress and findProgramAddress (solana-labs#23184) make sync * test: add test to ensure backwards compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
findProgramAddress is an async function but nothing about it requires it to be async
This makes it harder to write programs, for example if you wanted to use it in an array map you would have to use promise.all
For example if I wanted to find all the PDA for an account I would need to do something like the below
Proposed Solution
Remove async from createProgramAddress and findProgramAddress
The text was updated successfully, but these errors were encountered: