Code coverage tool is broken

[mvines]

Running the docker commands documented at https://github.com/solana-labs/solana#code-coverage result in rustc compilation failures. I see from some of the active PRs that this is also a problem in travis [1] [2].

This probably was not observed because in CI this command runs as a Travis after_success command [3], and failures in after_success will not turn the build red. As a part of fixing this I recommend moving the code coverage analysis into the Travis script command so it won't break unnoticed again.

[1] https://github.com/solana-labs/solana/blob/master/.travis.yml#L21
[2] https://travis-ci.org/solana-labs/solana/jobs/378490171
[2] https://github.com/solana-labs/solana/blob/master/.travis.yml#L20

[garious]

When we decided to use this hacky tooling, we anticipated these failures and that's why it's tucked under after_success. Failures on the nightly build are the same way. The Buildkite failures, on the other hand, are unacceptable. I hope to have that patched up in the next day or two. As for code coverage, we're hoping to migrate to a proper solution soon. Here' the ticket that tracks that: #177

[mvines]

Buildkite 😻. I saw hints of that in the PRs but nothing in the docs or code yet.
Looks like this issue is moot, I'll close it.

For buildkite I'd keep the pipeline description in the repo itself rather than building it up with their GUI., then use buildkite-agent pipeline upload ... [1] as the only pipeline step hard coded in the GUI to kick things off. Maybe you're already doing that but I don't see any hint of this in the repo right now, so sorry if I'm being obvious.

[1] https://buildkite.com/docs/pipelines/defining-steps#customizing-the-pipeline-file-path

[garious]

@aeyakovenko, ^^^ buildkite pipeline in the repo!

[mvines]

I’m happy to quickly setup in-repo pipelines here one evening for fun, I know buildkite stuff pretty well. Shouldn’t take very long and I miss playing around with it.

[aeyakovenko]

I can open source that repo :)

[aeyakovenko]

@garious the coverage failure is due to thin client test stalling. It only stalls with that build so there is a race there or needs a longer timer. 300ms is the default