This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Push the correct starting snapshot hashes to the cluster #20423
Assignees
Labels
Comments
This was referenced Oct 4, 2021
brooksprumo
added a commit
to brooksprumo/solana
that referenced
this issue
Oct 5, 2021
Now that CRDS supports incremental snapshot hashes, SnapshotPackagerService needs to push 'em! This commit does two main things: 1. SnapshotPackagerService now knows about incremental snapshot hashes, and will push SnapshotPackage::IncrementalSnapshot hashes to CRDS. 2. At startup, when loading from a full + incremental snapshot, the hashes need to be passed all the way to SnapshotPackagerService so it can push these starting hashes to CRDS. Those values have been piped through. Fixes solana-labs#20441 and solana-labs#20423
brooksprumo
added a commit
to brooksprumo/solana
that referenced
this issue
Oct 8, 2021
Now that CRDS supports incremental snapshot hashes, SnapshotPackagerService needs to push 'em! This commit does two main things: 1. SnapshotPackagerService now knows about incremental snapshot hashes, and will push SnapshotPackage::IncrementalSnapshot hashes to CRDS. 2. At startup, when loading from a full + incremental snapshot, the hashes need to be passed all the way to SnapshotPackagerService so it can push these starting hashes to CRDS. Those values have been piped through. Fixes solana-labs#20441 and solana-labs#20423
brooksprumo
added a commit
that referenced
this issue
Oct 8, 2021
…20442) Now that CRDS supports incremental snapshot hashes, SnapshotPackagerService needs to push 'em! This commit does two main things: 1. SnapshotPackagerService now knows about incremental snapshot hashes, and will push SnapshotPackage::IncrementalSnapshot hashes to CRDS. 2. At startup, when loading from a full + incremental snapshot, the hashes need to be passed all the way to SnapshotPackagerService so it can push these starting hashes to CRDS. Those values have been piped through. Fixes #20441 and #20423
dankelleher
pushed a commit
to identity-com/solana
that referenced
this issue
Nov 24, 2021
…olana-labs#20442) Now that CRDS supports incremental snapshot hashes, SnapshotPackagerService needs to push 'em! This commit does two main things: 1. SnapshotPackagerService now knows about incremental snapshot hashes, and will push SnapshotPackage::IncrementalSnapshot hashes to CRDS. 2. At startup, when loading from a full + incremental snapshot, the hashes need to be passed all the way to SnapshotPackagerService so it can push these starting hashes to CRDS. Those values have been piped through. Fixes solana-labs#20441 and solana-labs#20423
|
This issue has been automatically locked since there has not been any activity in past 7 days after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
SnapshotPackagerServicepushes SnapshotHashes to the cluster/CRDS. It also pushes a "starting" snapshot hash, based on the snapshot from boot. However, if a node startups from an incremental snapshot, the starting snapshot hash will be wrong.The
CrdsData::SnapshotHashesis supposed to be only full snapshots, but in the above case, the first hash pushed out could be an incremental snapshot incorrectly.To fix,
bank_fork_utils::load()needs to return the starting snapshot hashes for both full and incremental snapshots, and that needs to be propagated toSnapshotPackagerService, which will then consume it when spawning to push out the initial snapshot hashes.The text was updated successfully, but these errors were encountered: