-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BPF+LLVM: Add support for BPF shared objects #1805
Comments
I have the changes to support LLVM LD's creation of BPF based .so but they are in a local clone of the LLVM github mirror. Even if we forked LLVM to hold our changes temporarily expecting our users to build LLVM is probably to cumbersome. We could provide a binary... @mvines any other ideas? |
Yeah I think for now we simply need to provide LLVM binaries for our main two environments, macOS and Ubuntu 18.04 (sry WSL...), until the LLVM changes can be upstreamed and released in an official upstream version. This can take the form initially as a tarball attached to a github release in our fork of the LLVM github mirror. |
Actually better: let's just provide a docker image containing our forked LLVM. That'll work everywhere. |
Steps to sync and build the Solana LLVM forks:
To rebuild lld
I haven't submitted my lld changes there yet, still need to complete my modifications to rbpf/solana to use the ELF shared objects (rather then .o's) |
@mvines For the docker work, want to teach me to fish? |
Sure! So we want something that looks like the shellcheck docker image that we use here. This is a multi-stage Dockerfile, https://github.com/koalaman/shellcheck/blob/master/Dockerfile, that builds shellcheck in one image, then copies the resulting binary to a second image to keep the overall size down. Also get familiar with our Dockerfiles in the |
Fixed: #2012 |
* Fix SyscallLogPubkey doc comment * Update logging.rs
A single .o is too limiting
The text was updated successfully, but these errors were encountered: