Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary BPF verifier restriction on MUL64_IMM #17520

Closed
jackcmay opened this issue May 26, 2021 · 4 comments · Fixed by #18869
Closed

Unnecessary BPF verifier restriction on MUL64_IMM #17520

jackcmay opened this issue May 26, 2021 · 4 comments · Fixed by #18869
Assignees
@Lichtso
Labels
locked issue

Comments

@jackcmay
Copy link
Contributor

Problem

The BPF verifier enforces a non-zero imm for the MUL64_IMM instruction when it doesn't need to here:

solana/programs/bpf_loader/src/bpf_verifier.rs

Line 228 in 6b9d8d4

ebpf::MUL64_IMM => { check_imm_nonzero(&insn, insn_ptr)?; },

Proposed Solution

Featurize and remove this restriction
@jackcmay jackcmay mentioned this issue May 26, 2021
Merged
@jackcmay jackcmay self-assigned this May 26, 2021
@jackcmay jackcmay assigned Lichtso and unassigned jackcmay Jul 16, 2021
@Lichtso
Copy link
Contributor

Lichtso commented Jul 19, 2021

solana-labs/rbpf#201

@Lichtso
Copy link
Contributor

Lichtso commented Jul 23, 2021

Ready for feature gating as of #18869.
I marked the relevant line in the config with a TODO comment.

Do you want to add the feature flag or should I?

@jackcmay
Copy link
Contributor Author

As we discussed you are going to add it next week, thanks!

Lichtso added a commit to Lichtso/solana that referenced this issue Jul 26, 2021
@Lichtso
Feature gate for verify_mul64_imm_nonzero as discussed in solana-labs…
0dfb773 
…#17520.
@Lichtso Lichtso mentioned this issue Jul 26, 2021
Merged
Lichtso added a commit that referenced this issue Aug 4, 2021
@Lichtso
Bumps solana_rbpf to v0.2.14 (#18869)
0a63f65 
* Bumps solana_rbpf to v0.2.14

* Feature gate for verify_mul64_imm_nonzero as discussed in #17520.
Lichtso added a commit to Lichtso/solana that referenced this issue Nov 17, 2021
@Lichtso
Bump solana_rbpf to version v0.2.14 (solana-labs#18869)
8111d9a 
* Feature gate for verify_mul64_imm_nonzero as discussed in solana-labs#17520.
Lichtso added a commit to Lichtso/solana that referenced this issue Nov 17, 2021
@Lichtso
Bump solana_rbpf to version v0.2.14 (solana-labs#18869)
05ea046 
* Feature gate for verify_mul64_imm_nonzero as discussed in solana-labs#17520.
Lichtso added a commit to Lichtso/solana that referenced this issue Nov 17, 2021
@Lichtso
Bump solana_rbpf to version v0.2.14 (solana-labs#18869)
2aae20c 
* Feature gate for verify_mul64_imm_nonzero as discussed in solana-labs#17520.
Lichtso added a commit to Lichtso/solana that referenced this issue Nov 24, 2021
@Lichtso
Bump solana_rbpf to version v0.2.14 (solana-labs#18869)
f684fdb 
* Feature gate for verify_mul64_imm_nonzero as discussed in solana-labs#17520.
Lichtso added a commit to Lichtso/solana that referenced this issue Dec 3, 2021
@Lichtso
Bump solana_rbpf to version v0.2.14 (solana-labs#18869)
5d321f6 
* Feature gate for verify_mul64_imm_nonzero as discussed in solana-labs#17520.
Lichtso added a commit to Lichtso/solana that referenced this issue Dec 3, 2021
@Lichtso
Bump solana_rbpf to version v0.2.14 (solana-labs#18869)
fca8d5c 
* Feature gate for verify_mul64_imm_nonzero as discussed in solana-labs#17520.
Lichtso added a commit to Lichtso/solana that referenced this issue Dec 3, 2021
@Lichtso
Bump solana_rbpf to version v0.2.14 (solana-labs#18869)
852894a 
* Feature gate for verify_mul64_imm_nonzero as discussed in solana-labs#17520.
Lichtso added a commit to Lichtso/solana that referenced this issue Dec 3, 2021
@Lichtso
Bump solana_rbpf to version v0.2.14 (solana-labs#18869)
5a3a2bd 
* Feature gate for verify_mul64_imm_nonzero as discussed in solana-labs#17520.
Lichtso added a commit to Lichtso/solana that referenced this issue Dec 3, 2021
@Lichtso
Bump solana_rbpf to version v0.2.14 (solana-labs#18869)
fcefc87 
* Feature gate for verify_mul64_imm_nonzero as discussed in solana-labs#17520.
t-nelson pushed a commit that referenced this issue Dec 4, 2021
@Lichtso @t-nelson
Bump solana_rbpf to version v0.2.14 (#18869)
9d66458 
* Feature gate for verify_mul64_imm_nonzero as discussed in #17520.
Lichtso added a commit to Lichtso/solana that referenced this issue Dec 13, 2021
@Lichtso
Bump solana_rbpf to version v0.2.14 (solana-labs#18869)
cac1339 
* Feature gate for verify_mul64_imm_nonzero as discussed in solana-labs#17520.
Lichtso added a commit to Lichtso/solana that referenced this issue Dec 13, 2021
@Lichtso
Bump solana_rbpf to version v0.2.14 (solana-labs#18869)
d2d6d9d 
* Feature gate for verify_mul64_imm_nonzero as discussed in solana-labs#17520.
mvines pushed a commit that referenced this issue Dec 14, 2021
@Lichtso @mvines
Bump solana_rbpf to version v0.2.14 (#18869)
f9b7e24 
* Feature gate for verify_mul64_imm_nonzero as discussed in #17520.
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022

This issue has been automatically locked since there has not been any activity in past 7 days after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Lichtso Lichtso

Labels
locked issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bumps solana_rbpf to v0.2.14 Lichtso/solana
2 participants
@Lichtso @jackcmay