Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet sanity test is failing intermittently #1560

Closed
pgarg66 opened this issue Oct 20, 2018 · 8 comments
Closed

Wallet sanity test is failing intermittently #1560

pgarg66 opened this issue Oct 20, 2018 · 8 comments
Assignees

Comments

@pgarg66
Copy link
Contributor

pgarg66 commented Oct 20, 2018

Wallet sanity fails intermittently on testnet with the following stack trace:

stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1: std::sys_common::backtrace::print
             at libstd/sys_common/backtrace.rs:71
             at libstd/sys_common/backtrace.rs:59
   2: std::panicking::default_hook::{{closure}}
             at libstd/panicking.rs:211
   3: std::panicking::default_hook
             at libstd/panicking.rs:227
   4: std::panicking::rust_panic_with_hook
             at libstd/panicking.rs:475
   5: std::panicking::continue_panic_fmt
             at libstd/panicking.rs:390
   6: rust_begin_unwind
             at libstd/panicking.rs:325
   7: core::panicking::panic_fmt
             at libcore/panicking.rs:77
   8: core::result::unwrap_failed
   9: solana::wallet::parse_command
  10: solana_wallet::main
  11: std::rt::lang_start::{{closure}}
  12: std::panicking::try::do_call
             at libstd/rt.rs:59
             at libstd/panicking.rs:310
  13: __rust_maybe_catch_panic
             at libpanic_unwind/lib.rs:105
  14: std::rt::lang_start_internal
             at libstd/panicking.rs:289
             at libstd/panic.rs:392
             at libstd/rt.rs:58
  15: main
  16: __libc_start_main
  17: _start
@mvines
Copy link
Member

mvines commented Oct 23, 2018

@pgarg66 is this a dup of #1559? The backtrace here without a log for context is pretty rough to triage

@mvines mvines added this to the v0.10 Pillbox milestone Oct 23, 2018
@CriesofCarrots
Copy link
Contributor

CriesofCarrots commented Oct 23, 2018

I'm not certain this is the same issue because it doesn't produce the panic, but here is a PR CI with a wallet-sanity failure: https://buildkite.com/solana-labs/solana/builds/4205#016f1ca7-1909-48ac-a211-80c6b6c2ea4b

Here's another: https://buildkite.com/solana-labs/solana/builds/4258#be3becfa-c125-4bf1-a18e-7fcb9562de3b

@jackcmay , please share here if you have any others to hand.
While it may be the same underlying problem, #1559 is definitely a different symptom (airdrop failure on testnet boot).
(cc @mvines )

@mvines mvines modified the milestones: v0.10 Pillbox, v0.11 Tabletops Oct 26, 2018
@CriesofCarrots
Copy link
Contributor

@pgarg66 , do you have the panic message from before the stack trace?
I was finally able to produce a similar panic in parse_command from wallet-sanity by passing a bad character into the $signature variable, but I'm not sure if it's the same panic.

@pgarg66
Copy link
Contributor Author

pgarg66 commented Oct 26, 2018

Most likely it's the same. It was complaining about ':' being the extra character in the command.

@CriesofCarrots
Copy link
Contributor

Hmm, I don't see any obvious ways wallet-sanity would pick up an errant ':'
If you see it again, would you shoot me all the wallet-sanity output?

@mvines
Copy link
Member

mvines commented Dec 6, 2018

I've not seen this in a while, if another occurrence is not reported this week the issue can be closed.

@mvines mvines added the monitor Need more information. Waiting for this issue to reproduce label Dec 6, 2018
@pgarg66
Copy link
Contributor Author

pgarg66 commented Dec 6, 2018

👍

@mvines
Copy link
Member

mvines commented Dec 10, 2018

Not observed recently in CI

@mvines mvines closed this as completed Dec 10, 2018
@mvines mvines removed the monitor Need more information. Waiting for this issue to reproduce label Dec 10, 2018
vkomenda pushed a commit to vkomenda/solana that referenced this issue Aug 29, 2021
* stake-pool: Separate manager from owner

* Add manager pubkey to stake pool
* Differentiate manager functions from owner functions
* Include a `set_manager` function to be used by the owner
* Change the term `owner` to `authority` in the CLI for clarity

* Rename manager -> staker and owner -> manager

* Split staker, manager, and token owner in CLI

* "Do not disturb the boss"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants