Skip to content

Commit

Permalink
Merge pull request #174 from sakridge/fix_bind_for_external
Browse files Browse the repository at this point in the history
Fix bind so we can talk on external interfaces and surface send error
  • Loading branch information
garious authored May 4, 2018
2 parents 9d650ee + f4fbb5d commit fb9cb08
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/accountant_skel.rs
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ impl AccountantSkel {

fn notify_entry_info_subscribers(obj: &SharedSkel, entry: &Entry) {
// TODO: No need to bind().
let socket = UdpSocket::bind("127.0.0.1:0").expect("bind");
let socket = UdpSocket::bind("0.0.0.0:0").expect("bind");

// copy subscribers to avoid taking lock while doing io
let addrs = obj.entry_info_subscribers.lock().unwrap().clone();
Expand All @@ -100,7 +100,10 @@ impl AccountantSkel {
num_events: entry.events.len() as u64,
};
let data = serialize(&Response::EntryInfo(entry_info)).expect("serialize EntryInfo");
let _res = socket.send_to(&data, addr);
let res = socket.send_to(&data, addr);
if res.is_err() {
eprintln!("couldn't send response: {:?}", res);
}
}
}

Expand Down

0 comments on commit fb9cb08

Please sign in to comment.