Skip to content

Commit

Permalink
allow received to outpace window, we're already constraining repair
Browse files Browse the repository at this point in the history
correctly identify sender in ledger_window repair responses, enabling re-transmission
  • Loading branch information
rob-solana committed Aug 8, 2018
1 parent 8331aab commit ce8a4fa
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/crdt.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1025,7 +1025,7 @@ impl Crdt {
let out = entry.to_blob(
blob_recycler,
Some(ix),
Some(from.id),
Some(me.id), // causes retransmission if I'm the leader
Some(&from.contact_info.tvu_window),
);

Expand Down
4 changes: 2 additions & 2 deletions src/streamer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ fn blob_idx_in_window(debug_id: u64, pix: u64, consumed: u64, received: &mut u64
// the window. The worst case here is the server *starts* outside
// the window, none of the packets it receives fits in the window
// and repair requests (which are based on received) are never generated
*received = cmp::min(consumed + WINDOW_SIZE, cmp::max(pix, *received));
*received = cmp::max(pix, *received);

if pix >= consumed + WINDOW_SIZE {
trace!(
Expand Down Expand Up @@ -1155,7 +1155,7 @@ mod test {
);
assert_eq!(
wrap_blob_idx_in_window(0, 91 + WINDOW_SIZE, 90, 100),
(false, 90 + WINDOW_SIZE)
(false, 91 + WINDOW_SIZE)
);
assert_eq!(wrap_blob_idx_in_window(0, 89, 90, 100), (false, 100));

Expand Down

0 comments on commit ce8a4fa

Please sign in to comment.