Avoid panic when the release cache is empty

solana-labs · Feb 3, 2021 · ba0aa70 · ba0aa70
1 parent eacf920
commit ba0aa70
Showing 1 changed file with 22 additions and 19 deletions.
diff --git a/install/src/command.rs b/install/src/command.rs
@@ -817,26 +817,29 @@ pub fn gc(config_file: &str) -> Result<(), String> {
         .collect::<Vec<_>>();
     releases.sort_by(|a, b| b.1.partial_cmp(&a.1).unwrap()); // order by newest releases
 
-    let old_releases = releases.split_off(5); // Delete all but the 5 newest releases
-
-    if !old_releases.is_empty() {
-        let progress_bar = new_spinner_progress_bar();
-        progress_bar.set_length(old_releases.len() as u64);
-        progress_bar.set_style(
-            ProgressStyle::default_bar()
-                .template(&format!(
-                    "{}{}{}",
-                    "{spinner:.green} ",
-                    RECYCLING,
-                    "Removing old releases [{bar:40.cyan/blue}] {pos}/{len} ({eta})"
-                ))
-                .progress_chars("=> "),
-        );
-        for (release, _modified_type) in old_releases {
-            progress_bar.inc(1);
-            let _ = fs::remove_dir_all(&release);
+    const MAX_CACHE_LEN: usize = 5;
+    if releases.len() > MAX_CACHE_LEN {
+        let old_releases = releases.split_off(MAX_CACHE_LEN);
+
+        if !old_releases.is_empty() {
+            let progress_bar = new_spinner_progress_bar();
+            progress_bar.set_length(old_releases.len() as u64);
+            progress_bar.set_style(
+                ProgressStyle::default_bar()
+                    .template(&format!(
+                        "{}{}{}",
+                        "{spinner:.green} ",
+                        RECYCLING,
+                        "Removing old releases [{bar:40.cyan/blue}] {pos}/{len} ({eta})"
+                    ))
+                    .progress_chars("=> "),
+            );
+            for (release, _modified_type) in old_releases {
+                progress_bar.inc(1);
+                let _ = fs::remove_dir_all(&release);
+            }
+            progress_bar.finish_and_clear();
         }
-        progress_bar.finish_and_clear();
     }
 
     Ok(())