Distinguish turbine vs repair insertion metrics (#28980)

solana-labs · Nov 30, 2022 · 9a6ab5e · 9a6ab5e
1 parent 2427004
commit 9a6ab5e
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/ledger/src/blockstore.rs b/ledger/src/blockstore.rs
@@ -842,7 +842,13 @@ impl Blockstore {
                         leader_schedule,
                         shred_source,
                     ) {
-                        Err(InsertDataShredError::Exists) => metrics.num_data_shreds_exists += 1,
+                        Err(InsertDataShredError::Exists) => {
+                            if is_repaired {
+                                metrics.num_repaired_data_shreds_exists += 1;
+                            } else {
+                                metrics.num_turbine_data_shreds_exists += 1;
+                            }
+                        }
                         Err(InsertDataShredError::InvalidShred) => {
                             metrics.num_data_shreds_invalid += 1
                         }

diff --git a/ledger/src/blockstore_metrics.rs b/ledger/src/blockstore_metrics.rs
@@ -33,7 +33,8 @@ pub struct BlockstoreInsertionMetrics {
     pub num_recovered_failed_sig: usize,
     pub num_recovered_failed_invalid: usize,
     pub num_recovered_exists: usize,
-    pub num_data_shreds_exists: usize,
+    pub num_repaired_data_shreds_exists: usize,
+    pub num_turbine_data_shreds_exists: usize,
     pub num_data_shreds_invalid: usize,
     pub num_data_shreds_blockstore_error: usize,
     pub num_coding_shreds_exists: usize,
@@ -102,7 +103,16 @@ impl BlockstoreInsertionMetrics {
                 self.num_recovered_blockstore_error,
                 i64
             ),
-            ("num_data_shreds_exists", self.num_data_shreds_exists, i64),
+            (
+                "num_repaired_data_shreds_exists",
+                self.num_repaired_data_shreds_exists,
+                i64
+            ),
+            (
+                "num_turbine_data_shreds_exists",
+                self.num_turbine_data_shreds_exists,
+                i64
+            ),
             ("num_data_shreds_invalid", self.num_data_shreds_invalid, i64),
             (
                 "num_data_shreds_blockstore_error",