Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate the getStakeActivation RPC method #2864

Merged

Conversation

steveluscher
Copy link
Collaborator

This was deprecated in anza-xyz/agave#69

Copy link

changeset-bot bot commented Jun 27, 2024

⚠️ No Changeset found

Latest commit: 9878189

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator Author

steveluscher commented Jun 27, 2024

@@ -3640,6 +3640,8 @@ export class Connection {

/**
* Returns epoch activation information for a stake account that has been delegated
*
* @deprecated Deprecated in 1.18; will be removed in a future version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Maybe explicitly mention this is Solana/Agave 1.18, not Web3.js 1.18?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh. I mean… yeah. I'd have to do that for all of the comments in this file. I'll do that in the next PR.

@steveluscher steveluscher force-pushed the 06-27-deprecate_the_getstakeactivation_rpc_method branch from 43c4d05 to 6c9e302 Compare June 28, 2024 00:16
Copy link
Collaborator Author

steveluscher commented Jun 28, 2024

Merge activity

  • Jun 27, 5:19 PM PDT: @steveluscher started a stack merge that includes this pull request via Graphite.
  • Jun 27, 5:20 PM PDT: Graphite rebased this pull request as part of a merge.
  • Jun 27, 5:21 PM PDT: @steveluscher merged this pull request with Graphite.

@steveluscher steveluscher force-pushed the 06-27-deprecate_the_getstakeactivation_rpc_method branch from 6c9e302 to 9878189 Compare June 28, 2024 00:19
@steveluscher steveluscher merged commit 8bd58de into master Jun 28, 2024
6 checks passed
@steveluscher steveluscher deleted the 06-27-deprecate_the_getstakeactivation_rpc_method branch June 28, 2024 00:21
Copy link
Contributor

🎉 This PR is included in version 1.93.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants