[experimental] Create an error that the RPC can throw when there's an integer overflow #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Doing this, so that it can have its own `__tests__` folder, into which we'll put all the RPC method live tests.
…red among callers ## Summary We're about to have a situation where multiple different test runners are going to want to use a test validator. Since we can't run more than one on the same box, we're going to have to find a way for them to share one. The idea here is that the first caller to run this script will start the validator, and the last caller to quit will stop it. We achieve this through file locks and `bash` magic. ## Test Plan ``` ./scripts/start-shared-test-validator & ./scripts/start-shared-test-validator # Ctrl-C fg # Ctrl-C ```
… integer overflow ## Summary When you pass a value _into_ the RPC that exceeds `Number.MAX_SAFE_INTEGER` we're going to throw. This is preferable to the number hitting the RPC truncated. ## Test Plan ``` pnpm test:unit:browser pnpm test:unit:node ```
This was referenced Apr 1, 2023
|
🎉 This PR is included in version 1.75.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[experimental] Create an error that the RPC can throw when there's an integer overflow
Summary
When you pass a value into the RPC that exceeds
Number.MAX_SAFE_INTEGERwe're going to throw. This is preferable to the number hitting the RPC truncated.Test Plan
Stack created with Sapling. Best reviewed with ReviewStack.
getBlockHeightmethod #1230createDefaultRpc()method to the library #1227