This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
[experimental] Type the RPC API with bigint at the edge
#1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveluscher
force-pushed
the
pr1204
branch
2 times, most recently
from
1af8ae9 to
2d30d2f
Compare
## Summary I want all mocks to restored after each test run, so that no state or implementation bleeds between tests. This is incompatible with `jest-mock-fetch`. The solution is to manually restore the fetch mock for each and every test. ## Test Plan ``` pnpm dev ```
…ed for the Solana JSON RPC ## Summary `u64` values, in the Solana JSON RPC, are implemented as JavaScript numbers. This means that any number greater than `Number.MAX_SAFE_INTEGER` (9007199254740991) can't be trusted. This is tracked in solana-labs/solana#30741. In this PR we create a serializer that converts `bigint` values coming in from `@solana/rpc-core` to JavaScript `number`, as a concession. ## Test Plan ```shell pnpm test:unit:node ```
## Summary The _correct_ thing to do is be to use `bigint` wherever the Solana JSON RPC specfies `u64`. This PR endeavours to do that. *Note*: This isn't _actually_ safe, Because of an error in the design of the RPC. See #1204 for more information.
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[experimental] Type the RPC API with
bigintat the edgeSummary
The correct thing to do is be to use
bigintwherever the Solana JSON RPC specfiesu64. This PR endeavours to do that.Note: This isn't actually safe, Because of an error in the design of the RPC. See #1204 for more information.
Stack created with Sapling. Best reviewed with ReviewStack.
bigintat the edge #1205fetchmocks in Jest compatible with auto-resetting #1209