fix(library-legacy/deps): rpc-websockets@^7.11.0->^7.11.1

[legobeat]

[email protected] is broken and deprecated. This upgrades to fixed 7.11.1.

• Context

[changeset-bot]

⚠️ No Changeset found

Latest commit: c8474bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@changesets/[email protected]	environment, filesystem, shell Transitive: eval, unsafe	+41	13.3 MB	changesets-release-bot
npm/@types/[email protected]	None	0	1.97 MB	types
npm/[email protected]	None	+2	548 kB	rich_harris
npm/[email protected]	environment	+4	79.2 kB	sindresorhus
npm/[email protected]	None	0	46.7 kB	leebyron
npm/[email protected]	None	0	18.1 kB	turbobot
npm/[email protected]	filesystem Transitive: environment	+10	1.81 MB	simenb
npm/[email protected]	environment	0	118 kB	react-bot
npm/[email protected]	None	0	37.3 kB	lydell
npm/[email protected]	None	+5	780 kB	leo-buneev
npm/[email protected]	None	0	43.3 kB	infctr
npm/[email protected]	environment, filesystem Transitive: eval, shell	+34	8.29 MB	eslintbot
npm/[email protected]	None	0	0 B
npm/[email protected]	None	0	25.3 kB	simenb
npm/[email protected]	None	+1	54.1 kB	keplersj
npm/[email protected]	None	0	126 kB	rickhanlonii
npm/[email protected]	None	0	8.5 kB	simenb
npm/[email protected]	None	0	19.1 kB	simenb
npm/[email protected]	None	0	0 B
npm/[email protected]	network	0	162 kB	node-fetch-bot
npm/[email protected]	environment, filesystem, unsafe	0	8.25 MB	prettier-bot
npm/[email protected]	environment, filesystem	0	2.52 MB	lukastaegert
npm/[email protected]	environment, filesystem, unsafe Transitive: shell	+13	432 MB	blakeembrey
npm/[email protected]	environment, eval, filesystem Transitive: shell, unsafe	+16	432 MB	egoist
npm/[email protected]	None	0	30.6 kB	turbobot
npm/[email protected]	None	0	32.4 MB	typescript-bot

🚮 Removed packages: npm/[email protected], npm/[email protected]

View full report↗︎

[uafrontender]

@legobeat please check this issue #2762

In elpheria/rpc-websockets#161 they renamed files and now imports in solana-web3 package work incorrect. We should or update imports or set fixed version of "rpc-websockets": "7.11.0"

[legobeat]

@uafrontender Indeed. That's what this PR fixes.

[uafrontender]

@uafrontender Indeed. That's what this PR fixes.

Can you explain how does it fix? The problem arose because solana-web3 does not use a strict version of rpc-websockets, like 7.11.0. Instead, it uses ^7.11.0, which allows npm to install last compatible version, including 7.11.1. The 7.11.1 version of rpc-websockets was updated yesterday and is not compatible with the current code of solana-web3.

@legobeat actually your PR changes nothing because now after I run npm install @solana/web3.js its dependencies already include rpc-websockets: "^7.11.1"

[legobeat]

@uafrontender Indeed. That's what this PR fixes.

Can you explain how does it fix? The problem arose because solana-web3 does not use a strict version of rpc-websockets, like 7.11.0. Instead, it uses ^7.11.0, which allows npm to install last compatible version, including 7.11.1. The 7.11.1 version of rpc-websockets was updated yesterday and is not compatible with the current code of solana-web3.

Sorry for the dismissiveness 🤦

Pushed again with the actual fix.

actually your PR changes nothing because now after I run npm install @solana/web3.jsits dependencies already includerpc-websockets: "^7.11.1"`

Actually, actually not (look at the lockfile) ;). From a perspective of user of the package; it depends which of the two you end up with. But that's kind of besides the main point of making sure the actual issue fixed, which you rightly addressed!

[uafrontender]

Pushed again with the actual fix.

Thanks!

[steveluscher]

Thanks for catching this problem that I caused, then fixed, then caused again, then you fixed.

[softwarecurator]

pls fix

[github-actions]

🎉 This PR is included in version 1.91.9 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[plustokens]

Please consider using a fixed version from rpc-websockets to prevent any upcoming breaking changes again.
Use rpc-websockets version "7.11.1" instead "^7.11.1"

Can we have the workaround in description?

• Fix rpc-websockets version to avoid using the latest one retrieved by solana web3js:

npm install [email protected]

[nvm-delete]

@steveluscher This issue still persists in my Nextjs Pages router project, what should I do?

[steveluscher]

Do you have a repro you can send me?

[legobeat]

Upstream later deprecated 7.11.1 as well due to another issue... The fix involved advertising the package ESM only in 8.0.1: https://github.com/elpheria/rpc-websockets/commits/c4cb8372b37402e04e95008a6bcd808e7ccaef2a/

[steveluscher]

Ironically, it’s not actually ESM only in 8.0.1 either. See my comment here, and this follow up.

[github-actions]

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.