CI: Fixup patch crates script #7465
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem The locations of crates in the monorepo was moved to the `sdk/` dir in anza-xyz/agave#3498, but the patch script is still looking in the wrong location. This is why the downstream job was disabled in that PR. #### Summary of changes Get the patch script up to date with the new locations of the crates.
joncinque
added a commit
to joncinque/solana
that referenced
this pull request
Nov 6, 2024
#### Problem The downstream SPL job was disabled in solana-labs#3498 because the moved crates weren't correctly picked up in the SPL's patch script. The SPL patch script was fixed in solana-labs/solana-program-library#7465, but the jobs are still disabled. #### Summary of changes Re-enable the SPL downstream jobs.
joncinque
added a commit
to anza-xyz/agave
that referenced
this pull request
Nov 7, 2024
* CI: Re-enable downstream SPL job #### Problem The downstream SPL job was disabled in #3498 because the moved crates weren't correctly picked up in the SPL's patch script. The SPL patch script was fixed in solana-labs/solana-program-library#7465, but the jobs are still disabled. #### Summary of changes Re-enable the SPL downstream jobs. * Restrict which repo runs the job
|
This broke upstream monorepo, see: https://github.com/anza-xyz/agave/actions/runs/11727101736/job/32682222360?pr=3520 |
|
Ah darn, sorry about that, we can't support both versions at once unless we have different patch scripts for master and v2.1. I'll disable the downstream jobs in v2.1 for now |
joncinque
added a commit
to joncinque/solana
that referenced
this pull request
Nov 7, 2024
#### Problem The downstream jobs are failing on branch v2.1 due to solana-labs/solana-program-library#7465. #### Summary of changes Disable them for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The locations of crates in the monorepo was moved to the
sdk/dir in anza-xyz/agave#3498, but the patch script is still looking in the wrong location. This is why the downstream job was disabled in that PR.Summary of changes
Get the patch script up to date with the new locations of the crates.