This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
Increase dev mode opt-level for curve25519-dalek crate #7220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
reviewed
Aug 30, 2024
There was a problem hiding this comment.
Looks good to me! Can you just add a comment about why this is included? Maybe something like:
curve25519-dalek uses the `simd` backend by default in v4 if possible, which has very slow performance on some platforms with opt-level 0, which is the default for `dev` and `test` builds. This slowdown causes certain interactions in the solana-test-validator, such as verifying ZK proofs in transactions, to take much more than 400ms, creating problems in the testing environment.
To give better performance in solana-test-validator during tests and dev builds, we override the opt-level to 3 for the crate.
joncinque
approved these changes
Aug 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The curve25519-dalek crate could be quite slow on development mode relative to release mode. This could result in some tests failing (e.g. anza-xyz/agave#2252).
Summary of Changes
Bump up the opt-level for the crate in Cargo.