Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

[token-2022] Refactor tests to use ConfidentialTransferOption #7165

Merged

Conversation

samkim-crypto
Copy link
Contributor

@samkim-crypto samkim-crypto commented Aug 17, 2024

Problem

In the token22 tests, there are a bit of repeated logic to test instructions that require zkps in the form of instruction data, record account, and context state account. In the recent PRs (#7127, #7148) the tests for transfer and withdraw instructions have been refactored to tests the three variants of tests in a module way. The test logic for the other instructions could also benefit from this style of refactoring.

Summary of Changes

Made the refactoring changes for the empty account, configure account, and withdraw withheld fees instructions.

@samkim-crypto samkim-crypto marked this pull request as ready for review August 19, 2024 08:22
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@samkim-crypto samkim-crypto merged commit 55bcab1 into solana-labs:master Aug 19, 2024
31 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants