Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

program error: bump patch version #6592

Merged
merged 1 commit into from
Apr 18, 2024
Merged

program error: bump patch version #6592

merged 1 commit into from
Apr 18, 2024

Conversation

buffalojoec
Copy link
Contributor

Bumps the patch version of program error after #6590.

@buffalojoec buffalojoec requested a review from joncinque April 17, 2024 21:56
joncinque
joncinque reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless they need the new version, can we keep the downstream deps on 0.4.0? I got screwed pretty badly by the patch releases last time and wasted a whole day getting the deps to work out for token-cli because of patch bumps.

@buffalojoec
Copy link
Contributor Author

buffalojoec commented Apr 18, 2024 •
edited
Loading

Unless they need the new version, can we keep the downstream deps on 0.4.0? I got screwed pretty badly by the patch releases last time and wasted a whole day getting the deps to work out for token-cli because of patch bumps.

Oh yeah sure, but I think they'd have to get modified to say "4.0" since they use path, right? Even though Cargo would normally allow it, I think it gets tough with path.

@joncinque
Copy link
Contributor

joncinque commented Apr 18, 2024 •
edited
Loading

As long as we keep it as 0.4.0 everywhere, it should pull in either 0.4.0 or 0.4.1 depending on the lockfile. At least, it worked with my local testing

@buffalojoec
Copy link
Contributor Author

As long as we keep it as 0.4.0 everywhere, it should pull in either 0.4.0 or 0.4.1 depending on the lockfile. At least, it worked with my local testing

You are correct, sir.

joncinque
joncinque approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@buffalojoec buffalojoec merged commit ffecc94 into master Apr 18, 2024
8 checks passed
@buffalojoec buffalojoec deleted the program-err-bump branch April 18, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncinque joncinque joncinque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buffalojoec @joncinque