token-client: Refactor Message creation to use the same instructions everywhere
#6494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
approved these changes
Mar 26, 2024
| self.nonce_blockhash, | ||
| ) { | ||
| let mut message = Message::new_with_nonce( | ||
| token_instructions.to_vec(), |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the token client uses
Message::new_with_noncefor nonce transactions, which means that we need to do some copy-pasta on theinstructionsbefore simulating to find the compute unit limit.Solution
Extract the part from
Message::new_with_noncethat adds an instruction to the transaction.This actually fixes a bug where
Message::new_with_noncewas takingtoken_instructionsinstead ofinstructions.