Update solana dependency version to allow 2.0.0 #6182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
reviewed
Jan 25, 2024
Anchor.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [toolchain] | |||
| anchor_version = "0.29.0" | |||
| solana_version = "1.17.13" | |||
| solana_version = ">=1.17.13,<=2.0.0" | |||
There was a problem hiding this comment.
Do you know if Anchor supports this syntax? I don't think it does, so unless you're sure that it works, we should probably keep this as is
| @@ -16,4 +16,4 @@ cpi = ["no-entrypoint"] | |||
| default = [] | |||
|
|
|||
| [dependencies] | |||
| solana-program = "1.17.13" | |||
| solana-program = ">=1.17.13,<=2.0.0" | |||
There was a problem hiding this comment.
I did a little test, and specifying it in this way means that it will only ever pull in "2.0.0" and nothing higher. Would it make more sense to relax this further as:
Suggested change
| solana-program = ">=1.17.13,<=2.0.0" | |
| solana-program = ">=1.17.13,<=2" |
Then it can eventually pick up v2.1
There was a problem hiding this comment.
Yeah good idea. I was thinking it should be as restrictive as possible but we can always tighten the bound once we introduce an incompatibility.
joncinque
approved these changes
Jan 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are transitive dependencies from the solana monorepo that lead to split dependencies when the monorepo version number is bumped to 2.0. For example:
This leads to type incompatibilities.