Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

token cli: fix some clippy string errors #5580

Closed

Conversation

buffalojoec
Copy link
Contributor

This PR fixes three string-related clippy errors that I was seeing locally.

Our CI hasn't halted on this yet, but perhaps it's good to get ahead of?

Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@buffalojoec buffalojoec force-pushed the 10-18-token_cli_fix_some_clippy_string_errors branch from 2982252 to b689db8 Compare October 18, 2023 09:44
@buffalojoec buffalojoec requested a review from joncinque October 18, 2023 09:58
@buffalojoec
Copy link
Contributor Author

I'm actually not so sure this is useful right now. I used the stable toolchain:

cargo clippy --workspace --all-targets --features test-sbf -- --deny=warnings --deny=clippy::integer_arithmetic

@joncinque
Copy link
Contributor

I think these will get fixed automatically in #5575

@joncinque joncinque deleted the 10-18-token_cli_fix_some_clippy_string_errors branch October 18, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants