-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[token-cli] upgrade to clap-v3 #4506
Closed
samkim-crypto
wants to merge
11
commits into
solana-labs:master
from
samkim-crypto:token-cli/upgrade-clap-v3
Closed
[token-cli] upgrade to clap-v3 #4506
samkim-crypto
wants to merge
11
commits into
solana-labs:master
from
samkim-crypto:token-cli/upgrade-clap-v3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
stale
[bot only] Added to stale content; will be closed soon
label
Aug 10, 2023
samkim-crypto
removed
the
stale
[bot only] Added to stale content; will be closed soon
label
Aug 18, 2023
samkim-crypto
force-pushed
the
token-cli/upgrade-clap-v3
branch
from
September 3, 2023 17:00
c296c2e
to
65bfa07
Compare
…nstead of `u64`
samkim-crypto
force-pushed
the
token-cli/upgrade-clap-v3
branch
from
September 5, 2023 00:56
65bfa07
to
73e528e
Compare
samkim-crypto
force-pushed
the
token-cli/upgrade-clap-v3
branch
from
September 7, 2023 00:35
005461c
to
d8192ee
Compare
github-actions
bot
added
the
stale
[bot only] Added to stale content; will be closed soon
label
Sep 21, 2023
samkim-crypto
removed
the
stale
[bot only] Added to stale content; will be closed soon
label
Sep 27, 2023
github-actions
bot
added
the
stale
[bot only] Added to stale content; will be closed soon
label
Oct 11, 2023
samkim-crypto
removed
the
stale
[bot only] Added to stale content; will be closed soon
label
Oct 15, 2023
github-actions
bot
added
the
stale
[bot only] Added to stale content; will be closed soon
label
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#4511
Summary of Changes
This PR addresses all the "subtle changes" #4511 (comment) and a select number of changes in #4511 (comment) for the build and tests to pass.
Status: This PR is currently blocked until SPL upgrades to Solana version
1.16