Fix CpiGuard typo, but actually DRY processor methods #3791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 1, 2022 15:31
|
100% in favor, i copied the existing structure just because i thought it was done that way on purpose for style reasons |
2501babe
reviewed
Nov 2, 2022
| } | ||
| CpiGuardInstruction::Disable => { | ||
| msg!("CpiGuardInstruction::Disable"); | ||
| process_diasble_cpi_guard(program_id, accounts) |
There was a problem hiding this comment.
also thank you for catching this!
2501babe
approved these changes
Nov 2, 2022
I figured! Originally, only |
HaoranYi
pushed a commit
to HaoranYi/solana-program-library
that referenced
this pull request
Jul 19, 2023
* Fix typo * DRY CpiGuard * DRY RequiredMemoTransfers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading #3756 to understand what the new extension does, and stumbled on a typo.
I also noticed an opportunity to DRY the processor code, and then realized I introduced the verbose pattern myself in RequiredMemoTransfers. Wdyt about this tidying?